Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Add AS3 native initializers, abstract class metadata, remove separate super_init method entirely #18673

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

adrian17
Copy link
Collaborator

Requires #18358.

@Lord-McSweeney
Copy link
Collaborator

Worker and MorphShape can also be Abstract (unless you want to leave that to a follow-up, since there are several other classes that should be)

@adrian17
Copy link
Collaborator Author

adrian17 commented Nov 19, 2024

unless you want to leave that to a follow-up

I only modified the classes that I already needed to touch during the refactor, that's why I didn't notice Worker and MorphShape - but sure :) Will add them to the test too.

@adrian17 adrian17 force-pushed the avm2-drop-super-initializer branch 5 times, most recently from b722c3c to 49f5ac2 Compare November 19, 2024 19:24
@danielhjacobs danielhjacobs added A-avm2 Area: AVM2 (ActionScript 3) T-refactor Type: Refactor / Cleanup labels Nov 19, 2024
@adrian17 adrian17 force-pushed the avm2-drop-super-initializer branch 3 times, most recently from 71b39aa to 97e8756 Compare November 19, 2024 20:21
@adrian17 adrian17 enabled auto-merge (rebase) November 19, 2024 20:50
@adrian17 adrian17 merged commit fb8d950 into ruffle-rs:master Nov 19, 2024
22 checks passed
@adrian17 adrian17 deleted the avm2-drop-super-initializer branch November 19, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-refactor Type: Refactor / Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants